Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions has deprecated actions using Node 12 #2977

Closed
GCHQDeveloper314 opened this issue Jun 14, 2023 · 2 comments · Fixed by #2978
Closed

GitHub Actions has deprecated actions using Node 12 #2977

GCHQDeveloper314 opened this issue Jun 14, 2023 · 2 comments · Fixed by #2978
Assignees
@GCHQDeveloper314
Labels
automation GitHub Actions, CI/CD
Milestone
v2.1.0

Comments

@GCHQDeveloper314
Copy link
Member

Describe the problem
We are using some older versions of actions, or actions which have not been updated in a while. If these are using Node 12 then as of today they will no longer work. See announcement: All Actions will run on Node16 instead of Node12 by default.

To Reproduce
Go to Actions and see previous warnings about this for some of our workflows.

Desired behavior
No warnings for any actions workflows.
@GCHQDeveloper314 GCHQDeveloper314 added bug Confirmed or suspected bug automation GitHub Actions, CI/CD labels Jun 14, 2023
@GCHQDeveloper314 GCHQDeveloper314 added this to the v2.1.0 milestone Jun 14, 2023
@GCHQDeveloper314 GCHQDeveloper314 self-assigned this Jun 14, 2023
@GCHQDeveloper314
Copy link
Member Author

The following Workflows use actions (action-bump-semver & action-regex-match) from actions-ecosystem which do not have recent releases:

  • Create Release Branch
  • Create Hotfix Branch

From today these actions will be broken. Hopefully they will soon be updated. If this doesn't happen we'll need to remove these actions from the workflow. It might be better to replace them with use of sed.

@GCHQDeveloper314 GCHQDeveloper314 linked a pull request Jun 14, 2023 that will close this issue
Gh-2977: GitHub Actions has deprecated actions using Node 12 #2978
Merged
GCHQDeveloper314 added a commit that referenced this issue Jun 28, 2023
@GCHQDeveloper314
Merge branch 'develop' into gh-2977-fix-deprecated-actions
6e20a2c
@GCHQDeveloper314
Copy link
Member Author

The actions-ecosystem actions appear to be unmaintained and haven't been updated - action-bump-semver can be replaced with sed -r and action-regex-match is easily replaced with grep -E. This has been done in the associated PR.

GCHQDeveloper314 added a commit that referenced this issue Jun 29, 2023
@GCHQDeveloper314
Gh-2977: GitHub Actions has deprecated actions using Node 12 (#2978)
62d8331 
* Fix CodeQl workflow to use latest actions

* Fix Link Issue workflow to use latest action version
Was stuck on a patch release, now uses latest minor version

* Fix Release workflow to remove deprecated set-output
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

* Fix Link Issue workflow
Due to non-standard versioning (initial 'v') must use full version

* Replace broken actions with shell commands

* Review comment: Fix hotfix semver bump to be patch
@t92549 t92549 removed the bug Confirmed or suspected bug label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDeveloper314 GCHQDeveloper314

Labels
automation GitHub Actions, CI/CD
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

Gh-2977: GitHub Actions has deprecated actions using Node 12 gchq/Gaffer
2 participants
@t92549 @GCHQDeveloper314