Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve StoreProperties comments #2947

Closed
t92549 opened this issue May 12, 2023 · 1 comment · Fixed by #3128
Closed

Improve StoreProperties comments #2947

t92549 opened this issue May 12, 2023 · 1 comment · Fixed by #3128
Assignees
Labels
enhancement Improvement to existing functionality/feature tech-debt Relates to Technical Debt
Milestone

Comments

@t92549
Copy link
Contributor

t92549 commented May 12, 2023

* This is used.... seems to be leftover by mistake, there should be actual explanation here:

/**
* This is used....
* eg.gaffer.cache.service.class="uk.gov.gchq.gaffer.cache.impl.HashMapCacheService"
*/
public static final String CACHE_SERVICE_CLASS = CacheProperties.CACHE_SERVICE_CLASS;
/**
* This is used...
* CASE INSENSITIVE
* e.g. gaffer.cache.service.name.suffix="v2"
*/
public static final String CACHE_SERVICE_NAME_SUFFIX = "gaffer.cache.service.name.suffix";

@t92549 t92549 added the tech-debt Relates to Technical Debt label May 12, 2023
@t92549 t92549 added this to the v2.1.0 milestone May 12, 2023
@GCHQDev404 GCHQDev404 removed their assignment Aug 30, 2023
@GCHQDeveloper314
Copy link
Member

This file also needs fixing:

* This is used....
* e.g gaffer.federatedstore.isPublicAllowed=true
*/
public static final String IS_PUBLIC_ACCESS_ALLOWED = "gaffer.federatedstore.isPublicAllowed";
public static final String IS_PUBLIC_ACCESS_ALLOWED_DEFAULT = String.valueOf(true);
/**
* This is used....
* e.g gaffer.federatedstore.customPropertiesAuths="auth1"

@t92549 t92549 added the enhancement Improvement to existing functionality/feature label Nov 3, 2023
@t92549 t92549 modified the milestones: v2.1.0, v2.2.0 Nov 14, 2023
@t92549 t92549 self-assigned this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature tech-debt Relates to Technical Debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants