Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick constant class changes into v2-alpha #2929

Closed
t92549 opened this issue Mar 22, 2023 · 1 comment · Fixed by #2930
Closed

Cherry-pick constant class changes into v2-alpha #2929

t92549 opened this issue Mar 22, 2023 · 1 comment · Fixed by #2930
Assignees
@GCHQDeveloper314
Labels
enhancement Improvement to existing functionality/feature
Milestone
v2.0.0-alpha-0.6

Comments

@t92549
Copy link
Contributor

t92549 commented Mar 22, 2023

#2914
@t92549 t92549 added the enhancement Improvement to existing functionality/feature label Mar 22, 2023
@t92549 t92549 added this to the v2.0.0-alpha-0.6 milestone Mar 22, 2023
@GCHQDeveloper314 GCHQDeveloper314 linked a pull request Mar 23, 2023 that will close this issue
Gh-2929: Cherry pick constant class changes into v2-alpha #2930
Merged
@github-actions github-actions bot mentioned this issue Mar 23, 2023
Merged
t92549 pushed a commit that referenced this issue Mar 24, 2023
@GCHQDeveloper314 @ibrijesh
Gh-2929: Cherry pick constant class changes into v2-alpha (#2930)
72873e1 
* Gh-2914: Remove redundant constants class (#2927)

* #2914 Issue: Remove redundant constants class

* Simplify charset

* Remove erroneous use of charset with JSONSerialiser.serialise

* Use StandardCharsets inbuilt function
---------

Co-authored-by: GCHQDeveloper314 <[email protected]>
Signed-off-by: GCHQDeveloper314 <[email protected]>

* Copyright

* Fix diverged change to test

* Fix diverged change to exceptions

---------

Signed-off-by: GCHQDeveloper314 <[email protected]>
Co-authored-by: Brijesh Yadav <[email protected]>
@t92549
Copy link
Contributor Author

t92549 commented Mar 24, 2023

Closed by #2930

@t92549 t92549 closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDeveloper314 GCHQDeveloper314

Labels
enhancement Improvement to existing functionality/feature
Projects
None yet
Milestone
v2.0.0-alpha-0.6
Development

Successfully merging a pull request may close this issue.

Gh-2929: Cherry pick constant class changes into v2-alpha gchq/Gaffer
2 participants
@t92549 @GCHQDeveloper314