-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FederatedStore cache collision #2903
Comments
GCHQDev404
added a commit
that referenced
this issue
Feb 23, 2023
GCHQDev404
added a commit
that referenced
this issue
Feb 23, 2023
GCHQDev404
added a commit
that referenced
this issue
Feb 24, 2023
GCHQDev404
added a commit
that referenced
this issue
Feb 24, 2023
…ithout AddView and AddNamedOperations.
GCHQDev404
added a commit
that referenced
this issue
Feb 24, 2023
…ithout AddView and AddNamedOperations.
GCHQDev404
added a commit
that referenced
this issue
Feb 24, 2023
… be able to add a Proxy Store with or without AddView and AddNamedOperations.
GCHQDev404
added a commit
that referenced
this issue
Feb 24, 2023
… be able to add a Proxy Store with or without AddView and AddNamedOperations.
GCHQDev404
added a commit
that referenced
this issue
Feb 24, 2023
… be able to add a Proxy Store with or without AddView and AddNamedOperations.
GCHQDev404
added a commit
that referenced
this issue
Feb 24, 2023
… be able to add a Proxy Store with or without AddView and AddNamedOperations.
GCHQDev404
added a commit
that referenced
this issue
Feb 24, 2023
GCHQDev404
added a commit
that referenced
this issue
Feb 24, 2023
…ithin-a-federatedstore-environment' into gh-2903-part2 # Conflicts: # store-implementation/proxy-store/src/main/java/uk/gov/gchq/gaffer/proxystore/ProxyStore.java
GCHQDev404
added a commit
that referenced
this issue
Feb 24, 2023
…ithin-a-federatedstore-environment' into gh-2903-part2 # Conflicts: # store-implementation/proxy-store/src/test/java/uk/gov/gchq/gaffer/proxystore/integration/ProxyStoreResponseDeserialiserIT.java
GCHQDev404
added a commit
that referenced
this issue
Feb 28, 2023
…ithin-a-federatedstore-environment' into gh-2906-federatedstore-removegraph-must-clear-all-associated-caches
GCHQDev404
added a commit
that referenced
this issue
Mar 1, 2023
…-collision' into gh-2903-all-caches-require-suffix-to-avoid-collisions-within-a-federatedstore-environment # Conflicts: # store-implementation/proxy-store/src/main/java/uk/gov/gchq/gaffer/proxystore/ProxyStore.java
GCHQDev404
added a commit
that referenced
this issue
Mar 1, 2023
…-collision' into gh-2903-all-caches-require-suffix-to-avoid-collisions-within-a-federatedstore-environment
GCHQDev404
added a commit
that referenced
this issue
Mar 1, 2023
…ithin-a-federatedstore-environment' into gh-2903-part2 # Conflicts: # store-implementation/proxy-store/src/main/java/uk/gov/gchq/gaffer/proxystore/ProxyStore.java # store-implementation/proxy-store/src/test/java/uk/gov/gchq/gaffer/proxystore/integration/ProxyStoreResponseDeserialiserIT.java
GCHQDev404
added a commit
that referenced
this issue
Mar 2, 2023
…h-2903-return-proxy-store-to-no-cache-handlers # Conflicts: # core/store/src/main/java/uk/gov/gchq/gaffer/store/Store.java
GCHQDev404
added a commit
that referenced
this issue
Mar 3, 2023
…oxy-store-to-no-cache-handlers # Conflicts: # core/graph/src/test/java/uk/gov/gchq/gaffer/graph/GraphTest.java # store-implementation/proxy-store/src/main/java/uk/gov/gchq/gaffer/proxystore/ProxyStore.java # store-implementation/proxy-store/src/test/java/uk/gov/gchq/gaffer/proxystore/integration/ProxyStoreResponseDeserialiserIT.java
GCHQDev404
added a commit
that referenced
this issue
Mar 3, 2023
GCHQDev404
added a commit
that referenced
this issue
Mar 6, 2023
…2912) * gh-2886 FederatedStore remove double caching accidental collision. * gh-2887 Test fixed to user correct cache instance due to suffix/name change. * gh-2903 All Cache requires suffix * gh-2903 Test changes for Cache requiring suffix * gh-2903 Cherry Picked, improvements. * gh-2903 test fix * gh-2903 tidy. * gh-2886 PR change * gh-2886 review * gh-2903 PR changes. * gh-2903 PR changes. * gh-2906 RemoveGraph to optionally delete Caches. * gh-2906 spotless. * gh-2909 duplication * gh-2906 PR changes. --------- Co-authored-by: GCHQDev404 <[email protected]>
GCHQDev404
added a commit
that referenced
this issue
Mar 6, 2023
* gh-2886 FederatedStore remove double caching accidental collision. * gh-2886 FederatedStore remove double caching accidental collision. * gh-2887 Test fixed to user correct cache instance due to suffix/name change. * gh-2903 removing 1.12 cache tests and graphStorage zero argument constructor. * gh-2903 All Cache requires suffix * gh-2903 Test changes for Cache requiring suffix * gh-2903 spotless * gh-2903 Cherry Picked, improvements. * gh-2903 test fix * gh-2903 test fix * gh-2886 PR change * gh-2903 tidy. * gh-2886 review * gh-2886 PR request * gh-2886 PR request * gh-2903 merge conflicts * gh-2903 PR changes. * gh-2903 PR changes. * gh-2903 PR changes. * gh-2903 PR changes. * gh-2903 Cache changes for Score Resolvers. * gh-2903 Cache changes for Score Resolvers. * gh-2903 spotless * gh-2909 AddGraph with Handlers. * gh-2909 merge * gh-2903 spotless * gh-2909 improved getting operation declarations json * gh-2909 duplication * gh-2909 PR changes. --------- Co-authored-by: GCHQDev404 <[email protected]>
GCHQDev404
added a commit
that referenced
this issue
Mar 6, 2023
…oxy-store-to-no-cache-handlers # Conflicts: # store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/operation/handler/impl/FederatedAddGraphHandlerTest.java
GCHQDev404
added a commit
that referenced
this issue
Mar 6, 2023
GCHQDev404
added a commit
that referenced
this issue
Mar 6, 2023
GCHQDev404
added a commit
that referenced
this issue
Mar 6, 2023
This was
linked to
pull requests
Mar 7, 2023
t92549
added a commit
that referenced
this issue
Mar 31, 2023
Closed by #2907 |
t92549
added a commit
that referenced
this issue
Apr 12, 2023
* gh-2903 Cache changes for Score Resolvers. * gh-2903 spotless * gh-2903 Proxy stripped of unnessary Handlers and hooks, but exception in return object? * gh-2903 FederatedStore need to be able to add a Proxy Store with or without AddView and AddNamedOperations. * gh-2903 duplicate ProxyStore as alternative to FederatedStore need to be able to add a Proxy Store with or without AddView and AddNamedOperations. * gh-2903 Removing duplicate ProxyStore with Cache Handlers. instead IT with configured CacheHandlers. * Fixed ProxyStoreWithNamedOpNamedViewITs * Fixed new ProxyStoreWithNamedOpNamedViewITs class * Fix ProxyStore NamedOp deserialisation * Fix checkstyle --------- Co-authored-by: GCHQDev404 <[email protected]> Co-authored-by: t92549 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using the same cache implementation in a FederatedStore, the caches will collide.
To Reproduce
Suggested solution
All graphs require suffix usage, similar to FederatedGraphStroage Cache.
The text was updated successfully, but these errors were encountered: