Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated TODO comments #2872

Closed
GCHQDev404 opened this issue Jan 26, 2023 · 3 comments · Fixed by #2928
Closed

Remove outdated TODO comments #2872

GCHQDev404 opened this issue Jan 26, 2023 · 3 comments · Fixed by #2928
Assignees
@t92549
Labels
enhancement Improvement to existing functionality/feature tech-debt Relates to Technical Debt
Milestone
v2.0.0-alpha-0.6

Comments

@GCHQDev404
Copy link
Contributor

Describe the new feature you'd like
Action/remove Graph line:319 TODO.
@GCHQDev404 GCHQDev404 added the enhancement Improvement to existing functionality/feature label Jan 26, 2023
@GCHQDev404 GCHQDev404 added this to the v2.0.0-alpha-0.6 milestone Jan 26, 2023
@GCHQDeveloper314
Copy link
Member

This is a link to the TODO mentioned. I'm not sure that this ticket has enough detail as the TODO itself is unclear about the extent of what should be removed.

@n3101
Copy link

n3101 commented Mar 14, 2023

On the basis that no current team member knows anything about this, we have agreed to resolve this issue by removing the TODO comment.

@github-actions github-actions bot mentioned this issue Mar 16, 2023
Merged
@t92549 t92549 linked a pull request Mar 16, 2023 that will close this issue
Gh-2872: Remove outdated TODOs in code #2928
Merged
@t92549 t92549 self-assigned this Mar 16, 2023
@t92549 t92549 changed the title Remove Graph TODO - remove in V2 Remove outdates TODO comments Mar 16, 2023
@t92549 t92549 changed the title Remove outdates TODO comments Remove outdated TODO comments Mar 16, 2023
@t92549 t92549 added the tech-debt Relates to Technical Debt label Mar 16, 2023
@t92549
Copy link
Contributor

t92549 commented Mar 20, 2023

Closed by #2928

@t92549 t92549 closed this as completed Mar 20, 2023
t92549 added a commit that referenced this issue Mar 20, 2023
@t92549
Gh-2872: Remove outdated TODOs in code (#2928)
db57ca2 
* Remove TODOs

* Fix test TODOs

* Removed more outdated TODOs

* Spotless apply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t92549 t92549

Labels
enhancement Improvement to existing functionality/feature tech-debt Relates to Technical Debt
Projects
None yet
Milestone
v2.0.0-alpha-0.6
Development

Successfully merging a pull request may close this issue.

Gh-2872: Remove outdated TODOs in code gchq/Gaffer
4 participants
@GCHQDev404 @n3101 @t92549 @GCHQDeveloper314