Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Exceptions usage and review #2865

Closed
GCHQDev404 opened this issue Jan 18, 2023 · 2 comments · Fixed by #2925
Closed

Cache Exceptions usage and review #2865

GCHQDev404 opened this issue Jan 18, 2023 · 2 comments · Fixed by #2925
Assignees
@GCHQDev404
Labels
bug Confirmed or suspected bug
Milestone
v2.0.0-alpha-0.6

Comments

@GCHQDev404
Copy link
Contributor

Describe the bug
Following #2319 The caches now share a parent class Cache. However this combined the need for certain Exceptions to be thrown and required by some test. These Exceptions need to be reviewed. One example is a test to for when a Key is not found in the Cache an Exception is thrown. Keys not being found in a cache is not "exceptional behaviour".
@GCHQDev404 GCHQDev404 added the bug Confirmed or suspected bug label Jan 18, 2023
@GCHQDev404 GCHQDev404 added this to the v2.0.0-alpha-0.6 milestone Jan 18, 2023
@GCHQDev404 GCHQDev404 added the blocked Requires other issue(s) to be resolved label Feb 28, 2023
@GCHQDev404
Copy link
Contributor Author

Awaiting all cache PR to be approved

GCHQDev404 added a commit that referenced this issue Mar 6, 2023
@GCHQDev404
gh-2865 cache tidying.
8181402
@github-actions github-actions bot mentioned this issue Mar 6, 2023
Merged
@GCHQDev404 GCHQDev404 linked a pull request Mar 6, 2023 that will close this issue
gh-2865 Cache Exceptions usage and review #2925
Merged
GCHQDev404 added a commit that referenced this issue Mar 6, 2023
@GCHQDev404
gh-2865 cache tidying.
050c885
GCHQDev404 added a commit that referenced this issue Mar 7, 2023
@GCHQDev404
gh-2865 cache tidying. (#2925)
3ed0078
@t92549
Copy link
Contributor

t92549 commented Mar 7, 2023

Closed by #2925

@t92549 t92549 closed this as completed Mar 7, 2023
@t92549 t92549 removed the blocked Requires other issue(s) to be resolved label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDev404 GCHQDev404

Labels
bug Confirmed or suspected bug
Projects
None yet
Milestone
v2.0.0-alpha-0.6
2 participants
@GCHQDev404 @t92549