[Feature] Return version in getnetworkinfo the way ABC/BCHN does #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the version string in BCHD returns in a format different than other BCH nodes. This makes people parsing this value have a hard time, so I figured we should update it. The
version.Numeric()
function is only called in one place in any gcash code, and is exclusively used ingetnetworkinfo
.While this is a breaking change if someone is parsing it, I think it should be fine to change without a major version bump.
Here is a sample response: