Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ iOS Select new collapse options #483

Merged
merged 16 commits into from May 25, 2018
Merged

✨ iOS Select new collapse options #483

merged 16 commits into from May 25, 2018

Conversation

lukaszgoworko
Copy link
Contributor

solving Issue #231

Lukasz Goworko added 16 commits May 9, 2018 12:15
♻️ CollapsiblePickerIOS animapte Picker method
5e54a9f
✨ animate picker on isCollapsed prop
cd509ae 
animate when component will receive locals.isCollapsed
✨ set Animated start value depending on isCollapsed
ca0c024
✨ add isCollapsed to get locals in Select Component
8d686ca
✅ tests for Select:isCollapes
5fc67a5
🐛 use this for class methods
4ab36eb
✅ test for Select:onCollapse
666fdbe
🎨 rename callback onCollapse => onCollapseChange
4b5ccaa
🎨 rename collapse method for Select
58c6a4d
✨ trigger onCollapseChange callback, when collapse change
7ede8aa
🎨 rename method collapsePicker to togglePicker
d310a25
🎨 extract animatePicker method from togglePicker
733a677 
use it in componentWillReceiveProps
📝 updating readme
6b60e73 
add options description for isCollapsed and onCollapsedChange
🚨 removed lint warning with lint --fix
b796440
🔀 merging master and solving conflicts
51063d6
🐛 use old isCollapsed state on update, when option not set
cc32d09
@mattfordham
Copy link

Any word on merging this? Would love to use it!

@alvaromb
Copy link
Collaborator

Thanks for your collaboration!

Will try to merge & release on Friday.

@lukaszgoworko
Copy link
Contributor Author

@alvaromb If I can help you with something, just let me know 😄

@alvaromb
Copy link
Collaborator

LGTM

@alvaromb alvaromb merged commit d711ecc into gcanti:master May 25, 2018
@alvaromb
Copy link
Collaborator

Released: https://github.com/gcanti/tcomb-form-native/releases/tag/v0.6.13

@lukaszgoworko lukaszgoworko deleted the iOSSelectCollapsOptions branch May 30, 2018 08:08
alvaromb pushed a commit that referenced this pull request Sep 21, 2018
Solved antipattern issue
afb805a 
Reverted part of #483 due to arising bugs when locals change. Migrated from controlled-uncontrolled antipattern
@alvaromb alvaromb mentioned this pull request Sep 21, 2018
Merged
alvaromb added a commit that referenced this pull request Sep 21, 2018
@alvaromb
Solved antipattern issue (#527)
e740993 
Reverted part of #483 due to arising bugs when locals change. Migrated from controlled-uncontrolled antipattern
@bogan27 bogan27 mentioned this pull request May 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszgoworko @mattfordham @alvaromb