Set view as empty with double tap #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the "mIsEmpty" flag once the user double taps the signature pad.
gcacace
reviewed
Aug 27, 2017
| @@ -208,7 +208,10 @@ public boolean onTouchEvent(MotionEvent event) { | |||
| case MotionEvent.ACTION_DOWN: | |||
| getParent().requestDisallowInterceptTouchEvent(true); | |||
| mPoints.clear(); | |||
| if (isDoubleClick()) break; | |||
| if (isDoubleClick()) { | |||
There was a problem hiding this comment.
Can you extract from the function isDoubleClick() the part where the signature is cleared, so we can have the clearing part and the setIsEmpty(true) in the same place? I'd like to have isDoubleClick() as immutable method.
There was a problem hiding this comment.
Sure. Can you take a look at the new commit to check if that's what you wanted?
Removed `this.clearView();` from the `isDoubleClick()` method. It's now placed inside `onTouchEvent()` if the `isDoubleClick()` condition is `true`.
|
I've tested it, and it's not working as it should yet because this line keeps resetting the variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #91
Updated the
mIsEmptyflag once the user double taps the signature pad.Previous to this modification, if the user signed the view, and double tapped, the method
isEmpty()would always returnfalse.