Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate threading and concurrency issues #26

Open
fwcd opened this issue Apr 1, 2022 · 0 comments
Open

Investigate threading and concurrency issues #26

fwcd opened this issue Apr 1, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@fwcd
Copy link
Owner

fwcd commented Apr 1, 2022

While AppKit dispatches UI events on the main thread, SceneKit and SpriteKit seem to have their own private render threads, potentially resulting in race conditions, use-after-frees and other concurrency issues when the model is modified/accessed from different threads:

image

A potential solution would be to look into Swift 5's new actor classes.
@fwcd fwcd added the bug Something isn't working label Apr 1, 2022
@fwcd fwcd mentioned this issue Apr 1, 2022
Draft
fwcd added a commit that referenced this issue Apr 1, 2022
@fwcd
Batch achievements in PlayerControlComponent
3e3473e 
This fixes the concurrency bug from #26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fwcd