Fix #8 - Effort in string can be converted to integer minutes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compro-Prasad
force-pushed
the
fix/8
branch
3 times, most recently
from
6fdb683 to
17af893
Compare
joesteeve
reviewed
Mar 16, 2018
src/util.cxx
Outdated
| NAMESPACE__THITTAM_UTIL__START | ||
|
|
||
|
|
||
| std::string getString(const std::string &s, unsigned &pos) { |
There was a problem hiding this comment.
- We use 'snake_case' for function and variable names. So, please keep with that consistently.
- See how we place curly braces in the start of the function, in other code. Please maintain the same for consistency.
src/util.cxx
Outdated
| bool sign = 0; | ||
|
|
||
| if (s[pos] == '-') | ||
| sign = true, pos++; |
There was a problem hiding this comment.
Even if a block (if/for/while/) is only one line, you should include curly braces.
src/util.cxx
Outdated
| bool sign = 0; | ||
|
|
||
| if (s[pos] == '-') | ||
| sign = true, pos++; |
There was a problem hiding this comment.
These should be two statements.
src/util.cxx
Outdated
| for (unsigned i = 0; i < effort.length(); ++i) | ||
| { | ||
|
|
||
| while (isspace(effort[i])) i++; // Skip space |
There was a problem hiding this comment.
You should NEVER do this. This is very tricky for readability. Its much better to just 'continue'. That way the control of the iteration is in one place, i..e the 'for'.
src/util.cxx
Outdated
| case 'd': // day | ||
| minutes += 60.0 * hours_per_day * currentNumber; | ||
| break; | ||
| case 'h': minutes += 60.0 * currentNumber; break; |
Added tests and tests/CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
tests/CMakeLists.txtandtests/main.cxx