Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore GetGetPayloadResponse logging cleanup #465

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Conversation

metachris
Copy link
Collaborator

πŸ“ Summary

include some context in datastore.GetGetPayloadResponse logs


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

Codecov Report

Merging #465 (b9b3a0a) into main (2d3436d) will increase coverage by 0.90%.
The diff coverage is 54.05%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   29.94%   30.85%   +0.90%     
==========================================
  Files          24       24              
  Lines        4712     4739      +27     
==========================================
+ Hits         1411     1462      +51     
+ Misses       3106     3079      -27     
- Partials      195      198       +3     
Flag Coverage Ξ”
unittests 30.85% <54.05%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
database/mockdb.go 0.00% <0.00%> (ΓΈ)
datastore/datastore.go 21.08% <60.00%> (+21.08%) ⬆️
common/test_utils.go 44.68% <68.75%> (+12.42%) ⬆️

... and 1 file with indirect coverage changes

@metachris metachris merged commit af03847 into main Jun 16, 2023
@metachris metachris deleted the datastore-logging branch June 16, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants