Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[safety feature] getHeader cutoff, don't return bids to proposer after that #446

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

metachris
Copy link
Collaborator

πŸ“ Summary

Don't return bids to proposer after 2 seconds into the slot (i.e. if they have a slow network connection)


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2023

Codecov Report

Merging #446 (9020b0c) into main (d729fa5) will not change coverage.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   29.06%   29.06%           
=======================================
  Files          24       24           
  Lines        4649     4649           
=======================================
  Hits         1351     1351           
  Misses       3110     3110           
  Partials      188      188           
Flag Coverage Ξ”
unittests 29.06% <0.00%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
services/api/service.go 34.53% <0.00%> (ΓΈ)

@metachris metachris changed the title [safety feature] getHeader cutoff at t=2 (don't return bids to proposer after that) [safety feature] getHeader cutoff, don't return bids to proposer after that Jun 4, 2023
@metachris metachris merged commit a79812d into main Jun 6, 2023
@metachris metachris deleted the getheader-cutoff branch June 6, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants