Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix beacon http request timeout #414

Merged
merged 1 commit into from
May 17, 2023
Merged

fix beacon http request timeout #414

merged 1 commit into from
May 17, 2023

Conversation

metachris
Copy link
Collaborator

📝 Summary

Fix short beacon timeout (only use 5 sec for syncStatus, all others without timeout)

Bug Report:

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

michaelneuder
michaelneuder approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@michaelneuder michaelneuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metachris metachris merged commit 74750e4 into main May 17, 2023
@metachris metachris deleted the beacon-timeout branch May 17, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelneuder michaelneuder michaelneuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metachris @michaelneuder