Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-merge optimistic relaying minor tweaks. #402

Merged
merged 3 commits into from
May 12, 2023

Conversation

michaelneuder
Copy link
Collaborator

📝 Summary

A few minor things:

  1. Ordering APIs to be alphabetical.
  2. Fix for SetBlockBuilderStatus to only update is_optimistic when modifying multiple pubkey status'

⛱ Motivation and Context

We run these on our prod optimistic branch. they are minor cleanups that didn't make it into the main OR PR.


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@michaelneuder michaelneuder requested a review from metachris May 12, 2023 12:57
@codecov-commenter
Copy link

Codecov Report

Merging #402 (da3cf36) into main (15c14de) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   30.68%   30.70%   +0.01%     
==========================================
  Files          24       24              
  Lines        4507     4508       +1     
==========================================
+ Hits         1383     1384       +1     
  Misses       2960     2960              
  Partials      164      164              
Flag Coverage Δ
unittests 30.70% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/database.go 51.48% <100.00%> (+0.10%) ⬆️

@metachris
Copy link
Collaborator

metachris commented May 12, 2023

Fix for SetBlockBuilderStatus to only update is_optimistic when modifying multiple pubkey status'

What's the motivation for restricting it like this? Not sure I like that it behaves one way (update only is_otimistic) in this branch and another way (update all) in the other...

Copy link
Collaborator

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metachris metachris merged commit 126ab73 into main May 12, 2023
@metachris metachris deleted the mikeneuder-or-small-fixes branch May 12, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants