Skip to content
This repository was archived by the owner on Jul 20, 2021. It is now read-only.

Make key fields public. #23

Merged
merged 1 commit into from
May 31, 2017
Merged

Make key fields public. #23

merged 1 commit into from
May 31, 2017

Conversation

tferr
Copy link
Member

@tferr tferr commented May 30, 2017

This fixes a bug reported by Volko Straub (see tferr/hIPNAT#5 and tferr/hIPNAT@c45704a)

@tferr tferr merged commit 6b4a1f4 into fiji:master May 31, 2017
@imagejan
Copy link
Member

Why not adding setters and getters instead of making these fields public?

@tferr
Copy link
Member Author

tferr commented May 31, 2017

I think setters would only be useful if there were public methods to parse .traces files in a modular way. Right now there aren't: all the .traces parsing is done in a monolithic block. Getters would make sense, thought. Do you want me to replace it with getters()?

(Now I see this merge-without-waiting-long-enough-for-feedback was a bit despotic. I just thought nobody would care :) )

@imagejan
Copy link
Member

Adding getters and setters would simply be more in line with the ImageJ coding style.

Having private fields and get/set methods allows to change the implementation later on, without having to change the API in a backwards-incompatible way.

But don't worry, I just stumbled upon this and was tempted to ask, while having not much insight into the details of the source code...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants