Remove mutable defaults and allow more generic types

[sebastian-correa]

Summary

Solve #353 and #354 by removing mutable defaults and allowing more generic types than just lists/tuples/sets.

Details

Mutable defaults

Mutable defaults are a bad idea since they're evaluated at definition time and mutating a default value in 1 instance will mutate it in all of them.

This PR solves bad mutable defaults by allowing the user to pass (and defaulting to) None, which retains the old behavior.

More generic types

The code already worked for any Iterables, as we only iterated on the values. These changes reflect that reality by not forcing the user to pass lists, but allowing them to pass any iterables and storing them as lists internally (to not change the API).

str_types deprecation

str_types is a legacy thing from when the library supported Python 2, where the str_types were str and unicode. This PR deprecates the variable in favour of checking against str. This is a minor internal tweak.

Questions

I replaced the AssertionErrors with more aptly (IMO) suited TypeErrors and ValueErrors. Do you think this constitute a breaking change? Given the errors were raised only upon instantiation for validation and that they were undocumented behaviour, I'd say these are not breaking.

Notes

I'm totally open to any critique/requests, and even to not merging the PR if you think it's not a good idea. Just let me know!

[melroy89]

Thanks once again for the PR! I will look tomorrow into it.

[melroy89]

LGTM. I will test it locally a bit version. EDIT: Looks good! 🥳

Ps. Sorry I couldn't test it earlier. There was some kind of Chinese & Singapore DDoS attack happening. Hopefully not using fake-useragent python package.. 🤕

[melroy89]

Also this is no longer a problem indeed:

>>> ua3.browsers
['chrome', 'firefox', 'safari', 'edge']
>>> ua3.browsers.append("opera")
>>> ua3.browsers
['chrome', 'firefox', 'safari', 'edge', 'opera']
>>> ua2 = FakeUserAgent()
>>> ua2.browsers
['chrome', 'firefox', 'safari', 'edge']

[sebastian-correa]

Ps. Sorry I couldn't test it earlier. There was some kind of Chinese & Singapore DDoS attack happening. Hopefully not using fake-useragent python package.. 🤕

Haha, let's hope not. Thanks for the merge!