-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code & Docs cleanup + Package updates #351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoudewijnZwart
pushed a commit
to BoudewijnZwart/fake-useragent
that referenced
this pull request
Sep 24, 2024
* Remove unused imports. Remove fallback none check, fallback is always set by default today * Consistent import docs * Import FakeUserAgentError in utils.py at the top * Fix port with black * Update all packages at once * Revert "Fix port with black" This reverts commit 5f79171. * Revert "Update all packages at once" This reverts commit 524a29f. * Redo black & ruff fixes * Update virtualenv, validate pyproject, typing extentions and tox * Plus update cachetools, packaging and pyproject-api * ONLY update black, coverage and ruff * Only updating pyparsing, pyproject_hooks, typing_extenstions, validate-pyproject and virtualenv * ONly update attrs, exceptiongroup, fastjsonschema and importlib-resources * Revert "Only updating pyparsing, pyproject_hooks, typing_extenstions, validate-pyproject and virtualenv" This reverts commit 6c1e42a.
BoudewijnZwart
pushed a commit
to BoudewijnZwart/fake-useragent
that referenced
this pull request
Sep 24, 2024
* Remove unused imports. Remove fallback none check, fallback is always set by default today * Consistent import docs * Import FakeUserAgentError in utils.py at the top * Fix port with black * Update all packages at once * Revert "Fix port with black" This reverts commit 5f79171. * Revert "Update all packages at once" This reverts commit 524a29f. * Redo black & ruff fixes * Update virtualenv, validate pyproject, typing extentions and tox * Plus update cachetools, packaging and pyproject-api * ONLY update black, coverage and ruff * Only updating pyparsing, pyproject_hooks, typing_extenstions, validate-pyproject and virtualenv * ONly update attrs, exceptiongroup, fastjsonschema and importlib-resources * Revert "Only updating pyparsing, pyproject_hooks, typing_extenstions, validate-pyproject and virtualenv" This reverts commit 6c1e42a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR pointed out some code that needs to be cleaned up: #346