-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dimensions
does not emit change event when iPad first enters split view (multitasking)
#26830
Labels
Comments
Can you run If you believe this information is irrelevant to the reported issue, you may write `[skip envinfo]` alongside an explanation in your Environment: section.
|
Exactly the same. The behavior is like this video (on my tweet).
|
hramos
pushed a commit
that referenced
this issue
Dec 11, 2019
Summary: Fixes #26830 by removing version gating around `RCTUserInterfaceStyleDidChangeNotification` sent by `RCTRootView` and observing that notif for `Dimensions` changes. Also centralizes `RCTUserInterfaceStyleDidChangeNotification` constant definition in new `RCTConstants` file. Changelog: [iOS] [Fixed] - `Dimensions` module now updates on initial split screen Reviewed By: sammy-SC Differential Revision: D18931098 fbshipit-source-id: e9784be3f544f3b10360fbc2d6ad0324273b1a8f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Dimensions
does not emit change event when iPad first enters split view (multitasking).This only happens when you first move an app beside React Native app and they share each half of the screen. And
Dimensions
event listener does not get fired at this moment.When you start to swipe the splitting border in the middle, after you drop the touch, it works properly.
React Native version:
Steps To Reproduce
react-native init App
react-native run-ios
App.js
:Describe what you expected to happen:
Dimensions
should fire an event when iPad goes into multitasking and the App shrinks its size to the half.Reproduce repo
https://github.com/robertying/dimensions-ipad-multitasking
The text was updated successfully, but these errors were encountered: