-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new page documenting React Native's out-of-tree platform support #541
Conversation
Deploy preview for react-native ready! Built with commit 8a0d3bb https://deploy-preview-541--react-native.netlify.com Changes to Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would mention haul in addition to metro.
It would be great to include the first couple of error messages (e.g. when Accessibility.platform.js is missing) and how to fix them.
I almost wonder if I should make a PR that throws an error if you pass a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once the typo is fixed I think this can be merged. I'll reply to what Matt wrote separately
related to
We have been discussing about adding a "known issue" section to each component/page - you can check out how it would look here -> #519 So I think that if you want to add it you should follow that "approach" |
This PR adds a new page to the React Native docs that showcases other platforms that have been developed for React Native, and a bit documenting the API change that was added in facebook/react-native#20825 . In the future, this should be able to be expanded with more information on making/maintaining React Native platforms.