RN preset: support async iterators, for await of #747
Conversation
facebook-github-bot
added
CLA Signed
|
Happy New Year @motiz88 are you able to review this? |
|
Hi @rh389 , can you or someone at Meta give this a look please? I'm happy to make changes or close it if you're not interested in metro including support for async iterators. |
|
Pulling this in for a closer look - thanks! |
|
@rh389 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| { | ||
| dev: true, | ||
| type: 'module', | ||
| unstable_transformProfile: 'hermes-stable', |
There was a problem hiding this comment.
Can we remove this line and test the default transform profile instead? Alternatively we can have a separate test for hermes-stable, but the main test should exercise the default profile.
There was a problem hiding this comment.
Sure, will do
|
@rh389 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
* upstream/main: Use node devtools url (facebook#761) Publish 0.68.0 fix(website): add Algolia search API key (facebook#726) Change github actions trigger to use `main` branch (facebook#769) RN preset: support async iterators, for await of (facebook#747) Deploy 0.171.0 to xplat
Summary: **Summary** Async Generators and `for await` are part of ES2018. This PR adds `plugin-proposal-async-generator-functions` to the react native preset. See https://babeljs.io/docs/en/babel-plugin-proposal-async-generator-functions Fixes facebook#551 **Test plan** I added a test `transforms async generators` to `index-test.js`. Pull Request resolved: facebook#747 Reviewed By: motiz88 Differential Revision: D33621536 Pulled By: rh389 fbshipit-source-id: 0e07e6132e894fb5ad455627c2a33674f904a2fc
Summary: **Summary** Async Generators and `for await` are part of ES2018. This PR adds `plugin-proposal-async-generator-functions` to the react native preset. See https://babeljs.io/docs/en/babel-plugin-proposal-async-generator-functions Fixes facebook#551 **Test plan** I added a test `transforms async generators` to `index-test.js`. Pull Request resolved: facebook#747 Reviewed By: motiz88 Differential Revision: D33621536 Pulled By: rh389 fbshipit-source-id: 0e07e6132e894fb5ad455627c2a33674f904a2fc
Summary: **Summary** Async Generators and `for await` are part of ES2018. This PR adds `plugin-proposal-async-generator-functions` to the react native preset. See https://babeljs.io/docs/en/babel-plugin-proposal-async-generator-functions Fixes facebook#551 **Test plan** I added a test `transforms async generators` to `index-test.js`. Pull Request resolved: facebook#747 Reviewed By: motiz88 Differential Revision: D33621536 Pulled By: rh389 fbshipit-source-id: 0e07e6132e894fb5ad455627c2a33674f904a2fc
|
Why isn't this PR merged yet? Does someone know the reason? |
|
This was merged three years ago: The preset has since moved to the React Native repo, so if you're having issues that'd be the place to raise them. |
Summary
Async Generators and
for awaitare part of ES2018. This PR addsplugin-proposal-async-generator-functionsto the react native preset.See https://babeljs.io/docs/en/babel-plugin-proposal-async-generator-functions
Fixes #551
Test plan
I added a test
transforms async generatorstoindex-test.js.