Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: Integrate the bumpp #489

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Misc: Integrate the bumpp #489

merged 1 commit into from
Jan 22, 2025

Conversation

50rayn
Copy link
Contributor

@50rayn 50rayn commented Nov 25, 2024

Just saw the bash script update-version.sh, which help to synchronize the same version across all the package.json files in all packages, and recall the bumpp module. This module do the same and is high configurable, which allows to configure the commit message, tag name or even push after rising the version or not. All configuration can be done from CLI or the bump.config.ts. I created the configuration file as similar as the update-version.sh. Also observed that for each Release: X.X.X commit is just raised the version and commit with the same commit message and tag template, these details are also added in config file.

2024-11-26 at 12 52 31

@rokotyan
Copy link
Contributor

rokotyan commented Dec 2, 2024

@50rayn This is a great tool! But I'm having a problem with it. Every time I'm trying to update the version, it get's stuck in an endless loop saying Failed to locate the previous tag. Do you know how to fix it? I've tried creating a git tag manually, but it didn't help.

Screen.Recording.2024-12-02.at.10.06.47.AM.mp4

@50rayn 50rayn force-pushed the bumpp branch 2 times, most recently from 543dcc4 to 746329a Compare December 2, 2024 22:05
@50rayn
Copy link
Contributor Author

50rayn commented Dec 2, 2024

@rokotyan Played around and and found --ignore-scripts option based on docs. So it was fixed. But I'd rename the script from package.json from version to bumpp or smth else. Because the script version is reserved (docs). I tried locally to rename the version to bumpp, and it worked without setting the ignoreScripts flag.

@rokotyan
Copy link
Contributor

rokotyan commented Jan 17, 2025

I tried locally to rename the version to bumpp, and it worked without setting the ignoreScripts flag.

Tried this again, finally. Renamed version to bump in package.json and worked like a charm. @lee00678 I think it's the right thing to do.

@50rayn
Copy link
Contributor Author

50rayn commented Jan 20, 2025

@rokotyan If the script was renamed to bump, the option ignoreScripts from the config can be removed, since it's false by default.

@rokotyan
Copy link
Contributor

@50rayn Yep, I think we want to keep the scripts. I like the automatic tagging feature

Copy link
Collaborator

@lee00678 lee00678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@50rayn thanks for the contribution. Sorry it took a while.

@lee00678 lee00678 merged commit 0bedce5 into f5:main Jan 22, 2025
4 checks passed
@lee00678
Copy link
Collaborator

Hi @50rayn, we just used this feature to release the latest Unovis. Very nice feature. However, I noticed when run npm run version, the peerDependency @unovis/ts doesn't get updated to the latest version. I think we may need a postbump script for that?

@50rayn 50rayn deleted the bumpp branch February 19, 2025 19:07
@50rayn
Copy link
Contributor Author

50rayn commented Feb 19, 2025

Hello @lee00678. I'm not sure that bumpp doesn't have such functionality of upgrading the version from peerDependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants