-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TopoJSON Map Fixes #425
TopoJSON Map Fixes #425
Conversation
…dding topojson layer fixes: #400
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! This is great.
I just have one issue I've noticed. (pan or zoom on this map, the map disappears)
Screen.Recording.2024-08-07.at.11.30.08.AM.mov
events={{ | ||
[TopoJSONMap.selectors.feature]: { | ||
// click: c => console.log(c), | ||
}, | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused code?
Thanks for the fixes @reb-dev! |
Can you try |
My bad, it's working after the clean install. |
This PR addresses multiple issues with TopoJSON maps, makes some revisions to the TopoJSONMap component doc page, and adds a few new examples to the demo app.
Changes:
mapFitToPoints
is enabled will reset the view entirelymapFitToPoints
is enabled, the map will now refit to the new points (previously did nothing)