Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Solid support #422

Closed
wants to merge 6 commits into from
Closed

feat: Solid support #422

wants to merge 6 commits into from

Conversation

hngngn
Copy link
Contributor

@hngngn hngngn commented Jul 29, 2024

This PR adds SolidJS support to Unovis, expanding framework compatibility.

Copy link

github-actions bot commented Jul 29, 2024

CLA Assistant Lite bot ✅ All required contributors have signed the F5 CLA for this PR. Thank you!

@hngngn hngngn force-pushed the feat-solid-support branch from 4c011b8 to c7686fd Compare July 29, 2024 14:31
@hngngn
Copy link
Contributor Author

hngngn commented Jul 29, 2024

I have hereby read the F5 CLA and agree to its terms

@hngngn
Copy link
Contributor Author

hngngn commented Jul 29, 2024

recheck

@lee00678
Copy link
Collaborator

Hi @hngngn, thanks for this great contribution! We will review and get back to you soon!

@gabor-boros
Copy link

gabor-boros commented Sep 30, 2024

@lee00678 Any updates here? This PR has been open for a while now.

@rokotyan
Copy link
Contributor

@lee00678 I've tried it on my end, works like a charm. I would try to merge it asap and release 1.5.

Thanks for such a great contribution @hngngn! It's a shame it's taking us so long to review.

@lee00678
Copy link
Collaborator

@hngngn Thanks again for the great contribution and sorry for the delay.

lee00678
lee00678 previously approved these changes Oct 15, 2024
@lee00678
Copy link
Collaborator

@hngngn can you please do a rebase from main? Once all the check get passed, I will merge it in.

@rokotyan rokotyan mentioned this pull request Oct 21, 2024
@lee00678
Copy link
Collaborator

lee00678 commented Oct 31, 2024

Merged via #469

@lee00678 lee00678 closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants