Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component | Scatter: Label rendering fixes #413

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Conversation

reb-dev
Copy link
Collaborator

@reb-dev reb-dev commented Jul 11, 2024

This PR includes some minor refactoring and fixes the following issues:

  • When labelPosition === Position.Center, the labels aren't visible unless explicitly setting the label color
  • Scatter's bleed function adds extra space to the bottom (default label position), even when there are no labels present

@reb-dev reb-dev requested a review from lee00678 July 11, 2024 22:09
Copy link
Collaborator

@lee00678 lee00678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fix!

@rokotyan
Copy link
Contributor

Thanks for the fix @reb-dev

@reb-dev reb-dev merged commit 7e20a16 into main Jul 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants