Containers: Don't re-append SVG defs if they didn't change #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To test how the component react to re-rendering
|
@rokotyan do you know under what circumstance the flickering occurs? But regardless I think not re-render on each render is a good idea. |
|
@lee00678 On any event that triggers graph rendering, e.g. a prop change in React (a pretty common scenario) |
Gotcha. I see it happen now. Thanks for the info. |
lee00678
approved these changes
Jun 24, 2024
reb-dev
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SVG defs are re-appended on each render and it causes flickering. This PR fixes it.
Before (icons are flickering)
Screen.Recording.2024-06-21.at.2.46.41.PM.mp4
After (no flickering)
Screen.Recording.2024-06-21.at.2.45.52.PM.mp4