-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component | Graph: Allow user to set node positions #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add some more implementation for this.
Right now, providing x and y will automatically force the node positions (at least for GraphLayoutType.Force
, the other ones would get overridden I think). Shouldn't we prevent that from happening if GraphLayoutType.Precalculated
isn't specified?
607ad26
to
6b59a6e
Compare
That's a good point. I think you are right. I will update. |
60ea605
to
3332be5
Compare
My previous comment no longer applies after merging #396, we can just add @lee00678 Can you revert this PR to include your original changes? Then we can merge it |
3332be5
to
ad76252
Compare
@lee00678 Maybe I'm missing something but the changelog still shows me this |
ad76252
to
15a5e6e
Compare
Fixed. |
GraphInputNode
to allow the user to set node positions. This should make save and reload chart possible.