-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component | Axis: Add tick label rotation #394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lee00678 , looks good!
I noticed an edge case- when a label is very long at the end, the label gets cut off on initial render. On resize, it updates correctly but if we refresh the page we see it again.
Screen.Recording.2024-05-31.at.9.52.42.AM.mov
I think this may be an existing issue. Perhaps we should address this in a separate PR? Screen.Recording.2024-05-31.at.1.14.30.PM.mov |
You're totally right. Let's move to a separate issue. |
Yea margin calculation could be tricky. I took a brief look at it while implementing this feature. I will add an item to our issue list so we don't forget about it. |
Following this PR. Moved
rotate
out ofFitMode
.tickTextAngle
to allow user to pass in a number for label rotation. This feature should be used along withtickTextAlign
to get the desired result (we want to provide more control to the user).