Fix determination of Plane scaler #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The equation to determine the scalar for a plane from the normal and a point missed a minus, see for example https://en.wikipedia.org/wiki/Plane_%28geometry%29#Point-normal_form_and_general_form_of_the_equation_of_a_plane
Current coverage is 54.67% (diff: 0.00%)@@ master #13 diff @@
==========================================
Files 1 1
Lines 1635 1635
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 894 894
Misses 741 741
Partials 0 0
|
|
I'm nor sure whether the If it refers to the scalar part, this has more consequences to the code. At least all references to |
Follow up change required by negating scalar `k` of plane
Negated `k` of `Plane` requires negated `k` in `_intersect_line3_sphere`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The equation to determine the scalar for a plane from the normal and a point missed a minus, see for example https://en.wikipedia.org/wiki/Plane_%28geometry%29#Point-normal_form_and_general_form_of_the_equation_of_a_plane