feat: support for brotli #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should use |
blakeembrey
approved these changes
Oct 23, 2024
|
I really don't think there are any more changes to be made here. |
This comment was marked as outdated.
This comment was marked as outdated.
bjohansebas
force-pushed
the
feature/brotli
branch
2 times, most recently
from
ae9da60 to
162f14b
Compare
blakeembrey
reviewed
Dec 6, 2024
bjohansebas
force-pushed
the
feature/brotli
branch
from
162f14b to
4e8e083
Compare
This was referenced Dec 17, 2024
|
@wesleytodd any chance you have the time to review it once again so it could be merged? |
|
@bjohansebas @blakeembrey any idea when this PR will be merged and new version will be released? |
wesleytodd
approved these changes
Jan 8, 2025
|
Thanks to everyone who made this possible |
This was referenced Jan 8, 2025
Merged
|
@nicksrandall @danielgindi @bjohansebas This feature will save a huge chunk of the overall internet data transfers thanks to the widespread use of Express and 20 million weekly downloads of this package. Kudos for the efforts you've put in to enable this 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from #172 are brought in, with the exception of using the accept negotiation logic.