Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/#57 #67

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Bug/#57 #67

merged 2 commits into from
Nov 1, 2021

Conversation

MykhailoNester
Copy link
Contributor

closes #57

@MykhailoNester
- reject the encoded data if it contains a triplet of characters whic…
a55cf03 
…h, when decoded, results in an unsigned integer which is greater than 65535 (ffff in base 16);
@MykhailoNester
- code formatting;
b394974
@MykhailoNester MykhailoNester requested a review from a team as a code owner November 1, 2021 13:28
@MykhailoNester MykhailoNester merged commit 8c2872b into main Nov 1, 2021
@MykhailoNester MykhailoNester deleted the bug/#57 branch November 1, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandrsarapulovgl oleksandrsarapulovgl oleksandrsarapulovgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base45Decoder should reject triplets representing integers greater than 65535
2 participants
@MykhailoNester @oleksandrsarapulovgl