Fix format of validation clock

[martinreichart]

The current format of the validationClock in ExtermalParameter uses DateTimeFormatter.ISO_ZONED_DATE_TIME which includes a region information in square brackets. This leads to a DateTimeParseException (in DefaultCertLogicEngine.kt:111) when evaluating any rules that reference the validationClock.

[oleksandrsarapulovgl]

Thank you for finding and providing a fix @martinreichart !

As I see these changes are not fully applicable:

Could you please update it to support Android 21st API level?

[martinreichart]

@oleksandrsarapulovgl I will try to adapt this, but this seems to already have been issue before already - DateTimeFormatter.ISO_ZONED_DATE_TIME uses the DateTimeFormatterBuilder internally which is only available on API Level 26

[martinreichart]

@oleksandrsarapulovgl I have added core library desugaring to make the java.time packages available pre API level 26

[mlenkeit]

@martinreichart do you have sample data to reproduce this?

[martinreichart]

@mlenkeit any rule which references external.validationClock - in our case we noticed it the first time with https://github.com/eu-digital-green-certificates/dgc-business-rules-testdata/tree/main/AT/TR-AT-0006
What's tricky is that the exception is internally hidden in DefaultCertLogic and the evaluation of the rule leads to a status of OPEN with the exception added as a validationError. That's why we only caught it by evaluating a PCR-Test certificate and noticing that the rule for the expiry of the test did not fail

[mlenkeit]

@martinreichart that's interesting. All our tests successfully passed (or failed, depending on the rule) even without this change 🤔 We'll test with the rule that you referenced.

The fact that exceptions are/were caught also got aus. With #45, there's now at least an option to for the consumer of CertLogic to log the exception or otherwise respond to it.