Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxyauth #95

Merged
merged 9 commits into from
Dec 9, 2016
Merged

Proxyauth #95

merged 9 commits into from
Dec 9, 2016

Conversation

nevins-b
Copy link
Contributor

@nevins-b nevins-b commented Dec 9, 2016

resubmitting against auth branch :)

@kiwiz kiwiz merged commit 2f1efe2 into etsy:auth Dec 9, 2016
@kiwiz
Copy link
Contributor

kiwiz commented Dec 9, 2016

Merged, thanks! Will keep any discussions in this PR.

@kiwiz kiwiz mentioned this pull request Dec 9, 2016
Closed
@kiwiz
Copy link
Contributor

kiwiz commented Dec 16, 2016 •
edited
Loading

@nevins-b I've refactored the logic via 93925da. I removed the ability to parse a username (from an email) atm. I'll add it back in a follow up push, but any feedback is welcome!

@kiwiz kiwiz mentioned this pull request Jan 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nevins-b @kiwiz