-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add an entry about compiler warnings #8492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was missing.
Don't we always generate a warning/error on this case, even with Line 25 in 15e7d35
|
only 3 out of 4 options produce error: Lines 24 to 28 in 15e7d35
'None' never does, We do still need to mention the warnings, which even in 'Default' will give some useful advice. Specifically with C++, shouldn't we mention that it is undefined behaviour when trying to code like that? btw low-level routines that really do not return may still be coded like this int func() {
__builtin_unreachable();
} |
Argh, you are correct. Even trying to explicitly enable a warning like It seems the only way to make this automatically catch is to not use |
per esp8266#8421 and esp8266#8475 after checking HW, suggest to check SW as well by at least by enabling some or all compiler warnings (and also note of the IDE weirdest defaults causing issues we expected to stay solved)
per #8421 and #8475
after checking HW, suggest to check SW as well at least by enabling compiler warnings
(and also note of the IDE weirdest defaults causing issues we expected to stay solved)