Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support printing signed JSON Number #1539

Merged

Conversation

davidBar-On
Copy link
Contributor

@bmah888 bmah888 changed the title Support prining signed JSON Number Support printing signed JSON Number Jul 5, 2023
Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks. The original cJSON code prints this value as signed, but we accidentally made it unsigned when we applied fixes to support 64-bit integers after the last cJSON import.

@bmah888 bmah888 merged commit b4878b3 into esnet:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants