-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amoc core #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
fd5ec2f
to
f723b26
Compare
chrzaszcz
reviewed
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, I added some minor comments.
Remove empty lines, and elvis from rebar.config and Makefile. Elvis was removed because the latest version introduces too many breaking changes and compilation problems, it was too complicated to solve and for little benefit. It can be leaved as a future task to install elvis.
chrzaszcz
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal for a big change in how amoc works. Here, we separate metrics and APIs from what is actually the load-testing tooling, so that amoc itself can be a bare-bones dependency to be added to any project that wants to do load-testing.
TODOs so that this proposal is comprehensive and makes sense:
amoc-arsenal-xmpp
and have it possible to installamoc
andamoc_rest
and have just exactly the same functionality.exometer
code intoamoc-arsenal-xmpp
and have it possible to installexometer
andexometer_report_graphite
and have just exactly the same functionality.