Python smartparens Fix

[LaurenceWarne]

Hi 👋 I think this PR should fix #5 (at least the behaviour with python + smartparens).

What I think was happening was that if docstr-trigger-python detected the next three chars were """ it would remove them and not call (docstr--insert-doc-string (docstr-python--parse)) by virtue of the if-then-else (I don't think behaviour is intended? - please correct me on this if it is).

This path was always hit if smartparens mode was enabled since it inserts the three chars """ after the point once it detects three """ in a row.

Let me know if this fixes the issue ~ thanks Laurence

[jcs090218]

Thanks for the fix! I have opened another PR at #10. I think this should be the correct fix and your PR definitely gives me the hint about the conflict. Thanks for spending time on this! :D

[LaurenceWarne]

Cool 🙂 , I've pulled and python + smartparens works.

I see that (looking-at-p "\"\"\"") has been pulled into the first conditional, does this not mean that without smartparens automatically inserting """ after a user types """, (docstr--insert-doc-string (docstr-python--parse)) will not be triggered? - So docstrings won't be triggered unless a user has smartparens installed (or some equivalent)?

[jcs090218]

Since we have function docstr-trigger-python binds to command self-insert-command hence every click would trigger this function. I assumed the issue was smartparens does insertion for character " so it triggered the document string twice.

I see that (looking-at-p """"") has been pulled into the first conditional, does this not mean that without smartparens automatically inserting """ after a user types """, (docstr--insert-doc-string (docstr-python--parse)) will not be triggered? - So docstrings won't be triggered unless a user has smartparens installed (or some equivalent)?

Ah, yes. You are correct. I have tried with python-mode and I think python-mode does the insertion job for you? I don't know if #11 is the best solution since this package attend to support python-mode only for now. If you have another major mode that you use to code for python code and yet it does not help you insert """ then it won't be triggered...

---

Edit: Ah, okay. I figured that I have electric-pair-mode on. That's why I am able to get the document string triggered.

[LaurenceWarne]

I'm using master and the changes lgtm 👍 , shall I close this PR?

[jcs090218]

I'm using master and the changes lgtm 👍 , shall I close this PR?

Yes! Thanks for spending time looking into code for issue #5. :)

[LaurenceWarne]

No problem, thanks for your fast response 🙂