Add support for GitHub repository contents #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elwayman02
approved these changes
Apr 16, 2018
|
This looks great! @Dhaulagiri feel free to roll this out on a schedule that is convenient for your app, if this is good to go. |
Dhaulagiri
requested changes
Apr 16, 2018
|
|
||
| test('retrieving github repository contents', function(assert) { | ||
| assert.expect(4); | ||
| server.logging = true; |
| file: 'app.json' | ||
| }).then((content) => { | ||
| assert.githubRepositoryContentsOk(content); | ||
| assert.equal(store.peekAll('githubRepositoryContents').get('length'), 1); |
There was a problem hiding this comment.
can you add a 3rd parameter for this assert loads 1 repository contents?
| @@ -0,0 +1,12 @@ | |||
| import GitHubAdapter from './github'; | |||
There was a problem hiding this comment.
I prefer to explicit on these imports so that any file moves don't surprise us. Could you update this and all other new imports to have ember-data-github/<thing>/<name> in them
|
thanks @elwayman02 & @Dhaulagiri ! |
jmar910
force-pushed
the
jm-add-github-repo-content
branch
from
7334db5 to
fdd0f50
Compare
|
@Dhaulagiri done and done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a candidate model on the Heroku Dashboard for something that could live inside this addon