Add trees API support #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests. They need it because of the common base class. Fix a reference to the wrong entity in the tree test. Fix a typo.
elwayman02
reviewed
Jun 12, 2017
addon/serializers/github-tree.js
Outdated
| sha: resourceHash.sha, | ||
| url: resourceHash.url, | ||
| files: resourceHash.tree | ||
| .filter(item => item.type === 'blob') |
There was a problem hiding this comment.
These are js arrays, not Ember arrays.
elwayman02
reviewed
Jun 12, 2017
addon/serializers/github-tree.js
Outdated
| return files; | ||
| }, {}), | ||
| directories: resourceHash.tree | ||
| .filter(item => item.type === 'tree') |
There was a problem hiding this comment.
These are js arrays, not Ember arrays.
elwayman02
reviewed
Jun 12, 2017
addon/serializers/github-tree.js
Outdated
| .filter(item => item.type === 'blob') | ||
| .map(blob => blob.url), | ||
| trees: resourceHash.tree | ||
| .filter(item => item.type === 'tree') |
There was a problem hiding this comment.
Since you're having to do both of these filters twice, maybe it makes sense to alias them at the top of the method and then perform the reduce/map calls on the already filtered arrays.
elwayman02
requested changes
Jun 12, 2017
elwayman02
reviewed
Jun 23, 2017
addon/serializers/github-tree.js
Outdated
| sha: resourceHash.sha, | ||
| url: resourceHash.url, | ||
| files: blobItems | ||
| .reduce((files, blob) => { |
There was a problem hiding this comment.
Would prefer this moved up onto the same line now that it's just a variable name, better readability (and below as well for the other 3 calls)
elwayman02
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@elwayman02 Do you know of a better way to handle the tree entries? The
pathnames are part of the tree, not part of the referencedtreeorblob. I suspect this allows a single hash to appear in multiple directories or for the hash to remain the same if the file is renamed or moved. The result is that you have a referenced entity that is a superset of the entity's direct representation.