-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: settings action #4063
fix: settings action #4063
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
feat: [discord] community manager greet + timeout user
Currently, I couldn't get the onboard settings to work due to a few issues:
"I couldn't understand your settings update. Please try again with a clearer format."
After fixing the above, I still couldn’t apply settings because the result gets cleaned to an empty object if it’s not an array:
eliza/packages/core/src/actions/settings.ts
Line 391 in e20bd81
We should handle the case where the result is an object too.
Even after fixing those issues, I still couldn’t update the settings that were already configured.
This PR fixes the above issues.
Here’s the result after the fix (I confirmed the DB got updated — but if the context is too long, updating configured settings sometimes still fails. We should fix that separately later):