test: Add CLI tests for setup commands, agent commands, and customizations #4060

Samarthsinghal28 · 2025-03-24T17:41:33Z

Relates to

Ticket URL: Sifchain#394

Risks

Low – Changes are limited to CLI tests and should not affect other parts of the project.

Background

What does this PR do?

Adds CLI tests to the CLI package to improve test coverage and ensure CLI commands function correctly.

What kind of change is this?

Improvements (misc. changes to existing features)
Bug fixes (non-breaking change which fixes an issue)
Features (non-breaking change which adds functionality)
Updates (new versions of included code)

Documentation changes needed?

My changes do not require a change to the project documentation.
My changes require a change to the project documentation.

Testing

Where should a reviewer start?

Start by reviewing the new CLI test cases in the cli package.

Detailed testing steps

cd packages/cli
Run the following test commands:
- bun run test:setup-commands → Runs vitest test/setup-commands.test.js
- bun run test:agent-commands → Runs vitest test/agent-commands.test.js
- bun run test:agent-customisations → Runs vitest test/agent-customisation.test.js
Verify that all new CLI tests pass.
Check test coverage to ensure sufficient coverage of CLI functionality.

coderabbitai · 2025-03-24T17:41:41Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

monilpat · 2025-03-24T17:57:52Z

Thanks for adding this can you add either a screenshot or screen grab of a run of each of these tests? so output of bun run test:setup-commands → Runs vitest test/setup-commands.test.js bun run test:agent-commands → Runs vitest test/agent-commands.test.js bun run test:agent-customisations → Runs vitest test/agent-customisation.test.js

monilpat

Amazing job on these tests thank you for getting to these so quickly and overall doing a great job of implementation. Added some comments that apply across all files to the first test file. Please let me know if you have any questions!

monilpat · 2025-03-24T17:58:25Z

packages/cli/package.json

+    "clean": "rm -rf dist .turbo node_modules .turbo-tsconfig.json tsconfig.tsbuildinfo",
+    "test:setup-commands": "vitest test/setup-commands.test.js",
+    "test:agent-commands": "vitest test/agent-commands.test.js",
+    "test:agent-customisations": "vitest test/agent-customisation.test.js"


customizations for both the command and file name

monilpat · 2025-03-24T17:58:48Z

packages/cli/test/agent-commands.test.js

+        try {
+            await execAsync('elizaos stop', { reject: false });
+        } catch (e) {
+            // Server might not be running


Can we elizaLogger.error the exception in this case?

monilpat · 2025-03-24T17:59:25Z

packages/cli/test/agent-commands.test.js

+            bio: ["A test agent for integration testing."],
+            plugins: []
+        });
+        const projectRoot = path.resolve(__dirname, '../../..');


any way to get the root without a relative path here as the file structure could change - no worries if not

packages/cli/test/agent-commands.test.js

packages/cli/test/agent-customisation.test.js

harshal247 · 2025-03-25T14:40:46Z

In reference to: Thanks for adding this can you add either a screenshot or screen grab of a run of each of these tests? so output of bun run test:setup-commands → Runs vitest test/setup-commands.test.js bun run test:agent-commands → Runs vitest test/agent-commands.test.js bun run test:agent-customisations → Runs vitest test/agent-customisation.test.js

Output of each execution (03/24/2025):

bun run test:setup-commands → Runs vitest test/setup-commands.test.js

bun run test:agent-commands → Runs vitest test/agent-commands.test.js

bun run test:agent-customisations → Runs vitest test/agent-customisation.test.js

monilpat · 2025-03-26T15:07:42Z

Closing as another PR is taking care of this

Samarthsinghal28 added 2 commits March 24, 2025 22:52

cli commands test added

15fdb87

updated package.json to handle setup tests

8413090

monilpat reviewed Mar 24, 2025

View reviewed changes

packages/cli/test/agent-customisation.test.js Show resolved Hide resolved

monilpat changed the title ~~Add CLI tests for setup commands, agent commands, and customizations~~ test: Add CLI tests for setup commands, agent commands, and customizations Mar 24, 2025

wtfsayo added the V2 Eliza 0.2.0 label Mar 25, 2025

Merge branch 'v2-develop' into v2-develop

cf1cb22

harshal247 mentioned this pull request Mar 25, 2025

test: Updated code for "Add CLI tests for setup commands, agent commands, and customizations #4060" harshal247/eliza#1

Closed

Merge branch 'v2-develop' into v2-develop

8018515

harshal247 mentioned this pull request Mar 25, 2025

V2 develop #4073

Closed

Merge branch 'v2-develop' into v2-develop

c619105

harshal247 mentioned this pull request Mar 25, 2025

Updates CLI tests code based on the PR comments #4075

Merged

Merge branch 'v2-develop' into v2-develop

afe9340

monilpat closed this Mar 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Add CLI tests for setup commands, agent commands, and customizations #4060

test: Add CLI tests for setup commands, agent commands, and customizations #4060

Samarthsinghal28 commented Mar 24, 2025

coderabbitai bot commented Mar 24, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

monilpat commented Mar 24, 2025

monilpat left a comment

monilpat Mar 24, 2025

monilpat Mar 24, 2025

monilpat Mar 24, 2025

harshal247 commented Mar 25, 2025 •

edited

Loading

monilpat commented Mar 26, 2025

test: Add CLI tests for setup commands, agent commands, and customizations #4060

test: Add CLI tests for setup commands, agent commands, and customizations #4060

Conversation

Samarthsinghal28 commented Mar 24, 2025

Relates to

Risks

Background

What does this PR do?

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

coderabbitai bot commented Mar 24, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

monilpat commented Mar 24, 2025

monilpat left a comment

Choose a reason for hiding this comment

monilpat Mar 24, 2025

Choose a reason for hiding this comment

monilpat Mar 24, 2025

Choose a reason for hiding this comment

monilpat Mar 24, 2025

Choose a reason for hiding this comment

harshal247 commented Mar 25, 2025 • edited Loading

monilpat commented Mar 26, 2025

coderabbitai bot commented Mar 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

harshal247 commented Mar 25, 2025 •

edited

Loading