[Visual Refresh] Update floating border styles for panels #8427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes also issue with cut-off highlight border
- update deprecated token to new token
mgadewoll
force-pushed
the
borealis/207-panel-floating-border-update
branch
from
857d117 to
072e4a4
Compare
- this essentially reverts a previous change back to the original values
acstll
requested changes
Mar 14, 2025
There was a problem hiding this comment.
Amazing work, thank you @mgadewoll — I only found one small thing
- this was already implemented for tooltip and popover in Amsterdam as well, it shouldn't be removed
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @mgadewoll |
This was referenced Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes https://github.com/elastic/eui-private/issues/207
This PR updates how floating borders are applied to components that use panels.
Previously borders were applied as actual borders (using
border) on the panel element, which caused visual issues in light mode for flush fullwidth content where the 1px border created a 1px empty space.EuiTourEuiTourNote
EuiPanelhad already been updated to use pseudo element borders in a previous PR.This PR now shares this styling approach to more components.
Changes
euiPanelBorderStylesas sharable styles which applies a floating border via pseudo element::beforeto prevent it impacting contentEuiToasthighlight border is properly rounded (and not cut-off by the transparent floating border)QA
verify floating border is a) visible in dark mode and b) not visible in light mode for
UPDATED
INHERITED (selection)
Screenshots
Show screenshots
EuiToast highlight border fix
Floating border updates
General checklist
Checked in mobileChecked for accessibility including keyboard-only and screenreader modesAdded documentationProps have proper autodocs (using@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesAdded or updated jest and cypress testsIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)