Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Refresh] Fix incorrect backgroundLight json tokens #8316

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Feb 11, 2025

Summary

Important

This PR merges into a feature branch.

This PR fixes the values for 2 backgroundLight JSON tokens that were incorrect.

QA

  • verify that backgroundLight tokens in LIGHT mode use the color values for primitive colors of shade 20 (see the color definitions here)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mgadewoll

@mgadewoll mgadewoll marked this pull request as ready for review February 11, 2025 10:11
@mgadewoll mgadewoll requested a review from a team as a code owner February 11, 2025 10:11
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Great job, Lene!

Screenshot 2025-02-11 at 11 33 39

All backgroundLight tokens use 20 shades.

@mgadewoll mgadewoll merged commit eb26a87 into elastic:eui-theme/borealis Feb 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants