-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visual Refresh] Update docs to reflect new tokens #8306
[Visual Refresh] Update docs to reflect new tokens #8306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are looking solid! 🚢
Thank you @mgadewoll! I only have 2 non-blocking comments regarding text:
|
@acstll Thanks for the notes!
True! I missed that one 🫠
True! I missed updating the description as it's not actually using the JSDoc string anymore 🤦♀️ Thanks for the catch!
Ah yes, good call! 👍 |
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @mgadewoll |
👌 |
Summary
Important
This PR merges into a feature branch.
Closes https://github.com/elastic/eui-private/issues/174
This PR updates the EUI and EUI+ docs to ensure the new and/or updated color tokens are reflected.
Changes
dangerText
->textDanger
ortext
->textParagraph
)QA