Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Refresh] Provide legacy JSON theme tokens #8115

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Nov 4, 2024

Summary

closes https://github.com/elastic/eui-private/issues/138

Important

This PR merges into a feature branch.

This PR adds legacy JSON token files for the new theme.
These files were copied from the current theme and values updated according to the new theme specifications. Additionally tokens for accentSecondary have been added.

Note

No other additional tokens were added as these files are only meant to support existing usages and not promote new usages.

QA

  • CI passes
  • added testing packages on Kibana test instance update expected UI (e.g. editors and dashboard panels)
  • EUI docs:
    • sass token docs work as before for current theme and updates values when switching to new theme

@mgadewoll mgadewoll requested a review from tkajtoch November 4, 2024 10:19
@mgadewoll mgadewoll marked this pull request as ready for review November 4, 2024 13:55
@mgadewoll mgadewoll requested a review from a team as a code owner November 4, 2024 13:55
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great, but the Sass token docs seem to be broken now. Could you please take a look?

@mgadewoll
Copy link
Contributor Author

The changes look great, but the Sass token docs seem to be broken now. Could you please take a look?

@tkajtoch Could you specific why was broken in your testing? Cause for me it looks to be working as expected 🤔

@mgadewoll
Copy link
Contributor Author

@tkajtoch Thanks for pointing out the issue with docs not loading.
I fixed it in this commit. The issue was that a theme might not have been set yet to check on.

@mgadewoll mgadewoll requested a review from tkajtoch November 6, 2024 18:38
@mgadewoll mgadewoll force-pushed the eui-theme/138-update-json-tokens branch from 358d4f3 to d6ce8e0 Compare November 7, 2024 12:01
@mgadewoll
Copy link
Contributor Author

ℹ️ I rebased this branch with the feature branch it merges to after this PR was merged as there were conflicts.

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@mgadewoll mgadewoll merged commit ee4f853 into elastic:eui-theme/borealis Nov 7, 2024
4 checks passed
@mgadewoll mgadewoll deleted the eui-theme/138-update-json-tokens branch November 7, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants