-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visual Refresh] Provide legacy JSON theme tokens #8115
[Visual Refresh] Provide legacy JSON theme tokens #8115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great, but the Sass token docs seem to be broken now. Could you please take a look?
@tkajtoch Could you specific why was broken in your testing? Cause for me it looks to be working as expected 🤔 |
358d4f3
to
d6ce8e0
Compare
ℹ️ I rebased this branch with the feature branch it merges to after this PR was merged as there were conflicts. |
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
Summary
closes https://github.com/elastic/eui-private/issues/138
Important
This PR merges into a feature branch.
This PR adds legacy JSON token files for the new theme.
These files were copied from the current theme and values updated according to the new theme specifications. Additionally tokens for
accentSecondary
have been added.Note
No other additional tokens were added as these files are only meant to support existing usages and not promote new usages.
QA