Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Refresh] Update Typography scale #8103

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Oct 28, 2024

Summary

closes https://github.com/elastic/eui-private/issues/129

This PR adds updates to the typography scale for the new theme. These changes are directly taken from this PR that proposed the changes.

Important

This PR merges into a feature branch.

Note

Changes to the legacy JSON tokens will be done separately as part of this task.

QA

Note

This PR does not use the new theme yet in the docs, but the changes can be seen on this testing PR

  • compare docs font sizes for l, xl and xxl with production (they should be smaller now)
  • compare font weights for medium, semibold and bold with production (they should be less bold now)

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@mgadewoll mgadewoll marked this pull request as ready for review October 29, 2024 08:34
@mgadewoll mgadewoll requested a review from a team as a code owner October 29, 2024 08:34
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgadewoll mgadewoll merged commit a54f679 into elastic:eui-theme/borealis Oct 31, 2024
7 checks passed
@mgadewoll mgadewoll deleted the eui-theme/129-typography-scale-changes branch October 31, 2024 14:33
mgadewoll added a commit to mgadewoll/eui that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants