-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visual Refresh] Update Typography scale #8103
Merged
mgadewoll
merged 1 commit into
elastic:eui-theme/borealis
from
mgadewoll:eui-theme/129-typography-scale-changes
Oct 31, 2024
Merged
[Visual Refresh] Update Typography scale #8103
mgadewoll
merged 1 commit into
elastic:eui-theme/borealis
from
mgadewoll:eui-theme/129-typography-scale-changes
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview staging links for this PR:
|
💚 Build Succeeded
|
tkajtoch
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tkajtoch
pushed a commit
that referenced
this pull request
Oct 31, 2024
mgadewoll
added a commit
that referenced
this pull request
Nov 8, 2024
mgadewoll
added a commit
that referenced
this pull request
Nov 13, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Nov 20, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Nov 27, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Dec 16, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Dec 17, 2024
mgadewoll
added a commit
that referenced
this pull request
Jan 7, 2025
mgadewoll
added a commit
to mgadewoll/eui
that referenced
this pull request
Jan 20, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes https://github.com/elastic/eui-private/issues/129
This PR adds updates to the typography scale for the new theme. These changes are directly taken from this PR that proposed the changes.
Important
This PR merges into a feature branch.
Note
Changes to the legacy JSON tokens will be done separately as part of this task.
QA
Note
This PR does not use the new theme yet in the docs, but the changes can be seen on this testing PR
l
,xl
andxxl
with production (they should be smaller now)medium
,semibold
andbold
with production (they should be less bold now)