Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible upstream security issue #89

Closed
ghost opened this issue May 6, 2019 · 6 comments
Closed

possible upstream security issue #89

ghost opened this issue May 6, 2019 · 6 comments

Comments

@ghost
Copy link

ghost commented May 6, 2019

Keep an eye on this: passepartoutvpn/tunnelkit#97

I recommend to set this to 3 for eduVPN/Let's Connect! for iOS, possibly with a patch.

@ghost
Copy link
Author

ghost commented May 8, 2019

Seems it is being made configurable! For eduVPN/Let's Connect! we SHOULD set the security level to 3.

passepartoutvpn/tunnelkit#98

@jeroenleenarts
Copy link
Collaborator

👍 I'll update as soon as released as a CocoaPod.

jeroenleenarts added a commit that referenced this issue May 10, 2019
…yLevel`. This commit sets it to 3. Beware, this uses a direct git reference instead of a released version of TunnelKit. I will switch back as soon as possible. Fixes #89.
@ghost
Copy link
Author

ghost commented May 10, 2019

Did you test it, e.g. by setting it to 4 and 5 and trying to connect?

@jeroenleenarts
Copy link
Collaborator

jeroenleenarts commented May 13, 2019

Good point. I added a toggle in settings allowing selection of level 3, 4 or 5.

Everything checks out. Setting level 4 or 5 does not allow connecting due to a disallowed cipher suite or key size violation.

@ghost
Copy link
Author

ghost commented May 13, 2019

I would not make this configurable by the end user, but maybe you meant a toggle at build time, then that's a great idea!

@jeroenleenarts
Copy link
Collaborator

It was, but now it is not anymore. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant