Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added context menu option #30

Merged
merged 2 commits into from
Mar 10, 2014
Merged

Added context menu option #30

merged 2 commits into from
Mar 10, 2014

Conversation

martinbutt
Copy link

No description provided.

chrome.contextMenus.create({
"id": "spritzMenu"
,"title": "OpenSpritz this"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep names consistent (jetzt this? speed-read this with jetzt?).

Plus, Spritz is a trademark.
The Owner of OpenSpritz for Android said it this way:

Let's come up with an app title that can't be claimed as infringing on Spritz Inc. so we can publish on Google Play...

@h0ru5
Copy link
Collaborator

h0ru5 commented Mar 9, 2014

Apart from the Menu caption as commented inline, the PR looks good to me. Thanks!

@martinbutt
Copy link
Author

I've made the text change.

@h0ru5
Copy link
Collaborator

h0ru5 commented Mar 9, 2014

LGTM

ds300 added a commit that referenced this pull request Mar 10, 2014
Added context menu option
@ds300 ds300 merged commit 0a57957 into ds300:master Mar 10, 2014
@ds300
Copy link
Owner

ds300 commented Mar 10, 2014

Thanks, Martin! Can I add you to the contributors list in the readme?

@martinbutt
Copy link
Author

Sure! Happy to help.

On 10 March 2014 03:04, David Sheldrick [email protected] wrote:

Thanks, Martin! Can I add you to the contributors list in the readme?

Reply to this email directly or view it on GitHubhttps://github.com//pull/30#issuecomment-37167420
.

@ds300
Copy link
Owner

ds300 commented Mar 14, 2014

Hi @martinbutt! We want to re-license the project under the Apache License 2.0. It would be very much appreciated if you could reply here with the following agreement:

I license my contributions to the jetzt project under the Apache License 2.0.

thanks :)

@martinbutt
Copy link
Author

I license my contributions to the jetzt project under the Apache License 2.0.

:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants