-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added context menu option #30
Conversation
chrome.contextMenus.create({ | ||
"id": "spritzMenu" | ||
,"title": "OpenSpritz this" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep names consistent (jetzt this? speed-read this with jetzt?).
Plus, Spritz is a trademark.
The Owner of OpenSpritz for Android said it this way:
Let's come up with an app title that can't be claimed as infringing on Spritz Inc. so we can publish on Google Play...
Apart from the Menu caption as commented inline, the PR looks good to me. Thanks! |
I've made the text change. |
LGTM |
Thanks, Martin! Can I add you to the contributors list in the readme? |
Sure! Happy to help. On 10 March 2014 03:04, David Sheldrick [email protected] wrote:
|
Hi @martinbutt! We want to re-license the project under the Apache License 2.0. It would be very much appreciated if you could reply here with the following agreement:
thanks :) |
I license my contributions to the jetzt project under the Apache License 2.0. :-) |
No description provided.