turnstile #3158
Merged
turnstile #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah this is so nice! |
henrikskog
approved these changes
Apr 11, 2024
henrikhorluck
previously requested changes
Apr 11, 2024
Comment on lines
+279
to
+280
| registration_start=timezone.now() - timedelta(days=1), | ||
| registration_end=timezone.now() + timedelta(days=1), |
There was a problem hiding this comment.
Dette burde fikses i generate_event i stedet
apps/events/tests/view_tests.py
Outdated
Comment on lines
286
to
294
| self.assertInMessages("Du klarte ikke captchaen! Er du en bot?", response) | ||
| self.assertRedirects(response, event.get_absolute_url()) | ||
| self.assertInMessages("Vennligst vis at du er human.", response) |
There was a problem hiding this comment.
Dette er jo to forskjellige feil, "Du klarte ikke" vs "Du glemte" (nå "vennligst vis"), aka forskjellen mellom at captcha-responsen er med eller om innholdet er ugyldig, slik jeg forstår skal denne testen være for at den er med, men ugyldig, men du har endret den til å teste om den mangler?
There was a problem hiding this comment.
Det er den tidligere som viste feil, required og invalid var satt til samme streng
There was a problem hiding this comment.
fiksa også den her, står ikke human lenger men heller den nye fiksa
Co-authored-by: Henrik Hørlück Berg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend
dotkom/onlineweb-frontend#728
Video demonstrating ow4 and ow frontend
The first shows when auto fails and it becomes interactive, so worst case it's a click. Best case (very common), no click, like in the second part of the video.
Screen.Recording.2024-04-10.at.20.51.44.mov