π :: [#530] - μ ν리μΌμ΄μ λ²μ μ‘°ν 리νν λ§ #531
Conversation
dolong2
added
1οΈβ£ Priority: μ
Walkthroughμ΄λ² λ³κ²½ μ¬νμ λ컀 μ΄λ―Έμ§ νκ·Έλ₯Ό μ‘°ννλ μ μ€ν¬λ¦½νΈλ₯Ό μμ±νλ ν¨μλ₯Ό μΆκ°νλ κ²κ³Ό κ΄λ ¨λ©λλ€. Changes
Sequence Diagram(s)sequenceDiagram
participant S as GetApplicationVersionServiceImpl
participant F as FileContent
participant C as commandPort
S->>F: getImageVersionShellScriptContent(imageName, minVersion)
F-->>S: μ μ€ν¬λ¦½νΈ content λ°ν
S->>C: executeShellCommandWithResult(script)
C-->>S: νκ·Έ 리μ€νΈ λ°ν
Suggested labels
Poem
π Recent review detailsConfiguration used: CodeRabbit UI π Files selected for processing (6)
π€ Files with no reviewable changes (1)
β Files skipped from review due to trivial changes (1)
β° Context from checks skipped due to timeout of 90000ms (1)
π Additional comments (4)
β¨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
π§Ή Nitpick comments (3)
src/test/kotlin/com/dcd/server/core/domain/application/service/GetApplicationVersionServiceImplTest.kt (2)
19-28: ν μ€νΈ μ¬λ‘λ₯Ό λ μΆκ°νμΈμ.νμ¬ ν μ€νΈλ MYSQL μ ν리μΌμ΄μ νμ μ λν ν μ€νΈλ§ μννκ³ μμ΅λλ€. μ½λ μ λ’°μ±μ λμ΄κΈ° μν΄ λ€λ₯Έ μ ν리μΌμ΄μ νμ μ λν ν μ€νΈλ μΆκ°νλ κ²μ΄ μ’μ΅λλ€.
κ° μ ν리μΌμ΄μ νμ (SPRING_BOOT, NEST_JS, MARIA_DB, REDIS λ±)μ λν ν μ€νΈ μΌμ΄μ€λ₯Ό μΆκ°νκ³ , μ€λ₯ μν©μ λν ν μ€νΈλ ν¬ν¨νλ κ²μ΄ μ’μ΅λλ€.
32-35: ν μ€νΈ κ²μ¦ λ‘μ§ κ°μ μ΄ νμν©λλ€.νμ¬ ν μ€νΈ κ²μ¦μ λ¨μν κ²°κ³Ό ν¬κΈ°μ μ 체 λͺ©λ‘μ΄ μΌμΉνλμ§ νμΈν©λλ€. ν μ€νΈ μΌμ΄μ€κ° λ λͺ νν΄μ§λλ‘ κ²μ¦ λ‘μ§μ κ°μ νλ κ²μ΄ μ’μ΅λλ€.
λ€μκ³Ό κ°μ΄ κ²μ¦ λ‘μ§μ λ μΈλΆννμ¬ κ°μ νμΈμ:
then("latestκ° μμ΄μΌν¨") { result.size shouldBe 6 - result shouldBe tagList + // 첫 λ²μ§Έ νλͺ©μ΄ 'latest'μΈμ§ νμΈ + result.first() shouldBe "latest" + // λͺ¨λ νλͺ©μ΄ ν¬ν¨λμ΄ μλμ§ νμΈ + result shouldContainAll tagList + // λ²μ μμκ° λ΄λ¦Όμ°¨μμΌλ‘ μ λ ¬λμ΄ μλμ§ νμΈ + val numericVersions = result.filter { it != "latest" } + numericVersions shouldBe numericVersions.sortedByDescending { it } }src/main/kotlin/com/dcd/server/core/domain/application/service/impl/GetApplicationVersionServiceImpl.kt (1)
14-20: μμΈ μ²λ¦¬ μΆκ°κ° νμν©λλ€.μ ν리μΌμ΄μ νμ μ λν μ΄λ―Έμ§ μ΄λ¦κ³Ό μ΅μ λ²μ 맀νμ μ ꡬνλμμ§λ§, ν₯ν μλ‘μ΄ μ ν리μΌμ΄μ νμ μ΄ μΆκ°λ κ²½μ°μ λν μμΈ μ²λ¦¬κ° μμ΅λλ€.
whenννμμelseλΆκΈ°λ₯Ό μΆκ°νμ¬ μ μ μλ μ ν리μΌμ΄μ νμ μ λν μ²λ¦¬λ₯Ό κ°μ νμΈμ:val (baseImageName, minVersion) = when (applicationType) { ApplicationType.SPRING_BOOT -> "openjdk" to "12" ApplicationType.NEST_JS -> "node" to "17" ApplicationType.MARIA_DB -> "mariadb" to "10" ApplicationType.MYSQL -> "mysql" to "8" ApplicationType.REDIS -> "redis" to "6" + else -> throw IllegalArgumentException("μ§μνμ§ μλ μ ν리μΌμ΄μ νμ μ λλ€: $applicationType") }
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (3)
src/main/kotlin/com/dcd/server/core/common/file/FileContent.kt(1 hunks)src/main/kotlin/com/dcd/server/core/domain/application/service/impl/GetApplicationVersionServiceImpl.kt(2 hunks)src/test/kotlin/com/dcd/server/core/domain/application/service/GetApplicationVersionServiceImplTest.kt(2 hunks)
β° Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build and Test
...tlin/com/dcd/server/core/domain/application/service/impl/GetApplicationVersionServiceImpl.kt
Show resolved
Hide resolved
κ°μ
μμ λ΄μ©
체ν¬λ¦¬μ€νΈ
Summary by CodeRabbit
μλ‘μ΄ κΈ°λ₯
λ²κ·Έ μμ
리ν©ν°
ν μ€νΈ
ApplicationStaticWebAdapterμ λμμ κ²μ¦ν©λλ€.